two minor rhsm followups #989
Conversation
This could be its own whole new test, but it's simple enough to add one here. Signed-off-by: Colin Walters <[email protected]>
Just noticed this when reading the code; our cap-std-ext crate has a handy `atomic_write` API which streamlines exactly this use case. This avoids having a corrupted/half-written facts file if our process is interrupted, and also avoids a case where a reading process may temporarily see a half written file. Signed-off-by: Colin Walters <[email protected]>
| OpenOptions::new().write(true).create(true).truncate(true), | ||
| )?; | ||
| serde_json::to_writer_pretty(&mut bootc_facts_file, &facts)?; | ||
| root.atomic_replace_with(FACTS_PATH, |w| { |
|
Ug, the integration test on this run hit the dreaded
too... |
This is the equivalent of getting a stocking full of coal for Christmas. I am not looking forward to fighting this again in 2025! |
|
On this topic, I have now marked the integration tests as required. |
Followups to #977