-
Notifications
You must be signed in to change notification settings - Fork 785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vendor containers/common main #5085
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: umohnani8 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Once containers/common#1693 is merged, will remove the replace in go.mod |
Ephemeral COPR build failed. @containers/packit-build please check. |
92d1dab
to
d1fe675
Compare
e911e49
to
3c8f6de
Compare
Updated to vendor containers/common main. This will be ready to merge once tests are green |
Code that calls |
Opened containers/common#1696. |
This happens ~frequently. As long as callers are updated immediately, I think it's OK. |
3c8f6de
to
6fac672
Compare
LGTM but tests are not happy |
6fac672
to
ee7df0f
Compare
Pick up changes to move the platform code to its own directory. [NO NEW TESTS NEEDED] Signed-off-by: Urvashi Mohnani <[email protected]>
ee7df0f
to
7c8b510
Compare
/lgtm |
Pick up changes to move the platform code to its own directory.
What type of PR is this?
/kind other
What this PR does / why we need it:
Bumping the containers/common vendor to pick up some code move changes with the platform code
How to verify it
Buildah should build successfully
Which issue(s) this PR fixes:
Needed for the podman farm build PR
Special notes for your reviewer:
Does this PR introduce a user-facing change?