Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor in latest containers/storage and image #5290

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Jan 24, 2024

What type of PR is this?

/kind api-change
/kind bug
/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake
/kind other

What this PR does / why we need it:

How to verify it

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Copy link
Contributor

openshift-ci bot commented Jan 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhatdan rhatdan force-pushed the VENDOR branch 5 times, most recently from 71b9d33 to 17d5835 Compare February 2, 2024 00:51
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 3, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 5, 2024
@rhatdan rhatdan force-pushed the VENDOR branch 5 times, most recently from 58a9502 to 5253952 Compare February 7, 2024 01:29
@rhatdan
Copy link
Member Author

rhatdan commented Feb 7, 2024

@edsantiago Looks like a missing netavark is biting me, is this something you have fixed in newer images?

@edsantiago
Copy link
Member

@rhatdan it's ... sigh, complicated.

  • Yes, we have CI VMs available where f38 has netavark (1.9). However:
  • the f39 and rawhide images have netavark-1.10.1, which is broken in some respects, and I don't know if these affect buildah; and
  • my attempts to bring in netavark-1.10.2 are failing because that seems to be supercatastrophically broken. Please feel free to join the party at New VMs: we need netavark 1.10.3 automation_images#327

You are welcome to try bumping .cirrus.yml:IMAGE_SUFFIX to c20240201t143038z-f39f38d13 (what we're using in podman) and repushing. It's possible that the 1.10.1 bugs won't affect buildah. And given today's meeting-packed day, I would recommend that you just do so and let it churn away in the background. I will keep my fingers crossed.

@rhatdan rhatdan force-pushed the VENDOR branch 2 times, most recently from e50e3e6 to 137d485 Compare February 7, 2024 21:02
@TomSweeneyRedHat
Copy link
Member

@rhatdan is this a hold for v1.34.1?

@rhatdan
Copy link
Member Author

rhatdan commented Feb 8, 2024

Well this is not the vendor dance if that is what you are asking.

@rhatdan rhatdan added the lgtm label Feb 8, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit f2a11e6 into containers:main Feb 8, 2024
34 checks passed
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators May 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants