Makefile: list sources via find conditionally

[danishprakash]

Taken directly from podman's Makefile. The current list doesn't list vendor sources and therefore if you need to build and test your changes to vendor/ for testing a backport or anything else, it's required to modify the Makefile before attempting to do so.

/kind other

Signed-off-by: Danish Prakash [email protected]

[danishprakash]

@nalind I noticed you've added certain sources over time, so if there's a reason to selectively list sources that I'm not aware of, I can also only add vendor/*, that should also be good enough.

[nalind]

I hadn't considered that modifying files under vendor was a common enough case that the Makefile needed to account for it. Trying to add everything under vendor into the current SOURCES list seems like something that the bot that keeps our dependencies up to date would trip over, so if this doesn't slow down make, then I guess the thing to do is remove the part of the smoke test that fails.

[danishprakash]

I hadn't considered that modifying files under vendor was a common enough case that the Makefile needed to account for it.

I mean I use it quite often w/ podman when testing c/* changes and it's come in quite handy.

---

then I guess the thing to do is remove the part of the smoke test that fails.

We were validating the sources because we were listing them manually, I guess moving to a finder cmd, I don't see the need for a validation anymore, wdyt?

Do we have benchmarks to test if there's a performance degradation? I can think of vendor bumps as an additional trigger for rebuilds, can't think of anything major that should have an impact.

[Luap99]

If a go file changed we should rebuild, in vendor/ or not. Because if I do a dependency bump locally via gp.mod then make buildah currently doesn't rebuild so this is clearly broken. As such I think this here is the right idea.

I don't see any advantage of listing all the packages here so the find seems much better to me. Even if it would pick something up that does not need to trigger a rebuild all the time go rebuilds are fast anyway so I would not be concerned about speed.

[rhatdan]

LGTM

[nalind]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danishprakash, nalind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [nalind]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kolyshkin]

You should probably also remove *.go files from some of the targets that use `$(SOURCES). For example:

bin/buildah: $(SOURCES) cmd/buildah/*.go internal/mkcw/embed/entrypoint_amd64.gz

Here cmd/buildah/*.go is becoming redundant.

[danishprakash]

Thanks for the catch, updated.

[TomSweeneyRedHat]

LGTM

[rhatdan]

/lgtm