Get hook stage from stdin's 'status' value #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using CRI-O-specific arguments, environment variables, or PID positive-ness, use the state's REQUIRED 'status' property [1] to ensure we're being called on a created container (and not a running container or a stopped container). Also, do not error if 'pid' is unset (it isn't REQUIRED for 'stopped' on Linux [2]) in general, but do error if pid is not set positive for 'created' containers (where it's REQUIRED on Linux [2]). [1]: https://github.com/opencontainers/runtime-spec/blame/v1.0.1/runtime.md#L16 [2]: https://github.com/opencontainers/runtime-spec/blame/v1.0.1/runtime.md#L25
This was referenced Feb 22, 2018
|
My concern here is that this will work correctly with an older docker-runc that we are using in docker-1.12 and docker-1.13, Did these versions of runc follow those rules. If not we would need to keep the checking of argv1. |
|
@rhvgoyal PTAL |
|
Docker 1.12.0 passed in the state, but the state did not include |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using CRI-O-specific arguments, environment variables, or PID positive-ness, use the state's REQUIRED
statusproperty to ensure we're being called on a created container (and not a running container or a stopped container). Also, do not error ifpidis unset (it isn't REQUIRED forstoppedon Linux) in general, but do error ifpidis not set positive forcreatedcontainers (where it's REQUIRED on Linux).This is ground-work for dropping the
stageenvironment variable from CRI-O (cri-o/cri-o#1360).