split subpackage tty7 into single spec and chmod +x tools #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Douglas Schilling Landgraf <[email protected]>
Signed-off-by: Douglas Schilling Landgraf <[email protected]>
tools that we execute should be chmod +x Signed-off-by: Douglas Schilling Landgraf <[email protected]>
dougsland
requested review from
rhatdan,
lsm5,
Yarboa,
sandrobonazzola,
nsednev,
aesteve-rh,
pengshanyu and
kleinffm
as code owners
Yarboa
reviewed
Dec 31, 2024
There was a problem hiding this comment.
Please run this command pre-commit run --show-diff-on-failure --color=always --all-files please add the fixed file and commit again
I do not see here
any additional package, created, is it ok?
https://copr.fedorainfracloud.org/coprs/packit/containers-qm-685/packages/
yes, it's disabled by default. |
Signed-off-by: Douglas Schilling Landgraf <[email protected]>
|
No answer to my point here: #674 so I am continuing with the split in the main repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.