fix: adding multiple listeners to the same element (#1153)

* fix: adding multiple listeners to the same element * replace deprecated dibi::IDENTIFIER with Fluent::Identifier
contributte · Nov 1, 2024 · 04f0e4b · 04f0e4b
1 parent 0105ca3
commit 04f0e4b
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/assets/plugins/features/autosubmit.ts b/assets/plugins/features/autosubmit.ts
@@ -46,6 +46,11 @@ export class AutosubmitPlugin implements DatagridPlugin {
 				const form = submitEl.closest("form");
 				if (!form) return;
 
+				if (submitEl.dataset.listenersAttached === "true") {
+					return; // Skip if listeners are already attached
+				}
+				submitEl.dataset.listenersAttached = "true";
+
 				// Select auto-submit
 				if (submitEl instanceof HTMLSelectElement) {
 					submitEl.addEventListener("change", () => datagrid.ajax.submitForm(form));

diff --git a/src/DataSource/DibiFluentDataSource.php b/src/DataSource/DibiFluentDataSource.php
@@ -13,7 +13,6 @@
 use Contributte\Datagrid\Filter\FilterText;
 use Contributte\Datagrid\Utils\DateTimeHelper;
 use Contributte\Datagrid\Utils\Sorting;
-use dibi;
 use Dibi\Fluent;
 use Dibi\Helpers;
 use ReflectionClass;
@@ -167,7 +166,7 @@ protected function applyFilterText(FilterText $filter): void
 		$or = [];
 
 		foreach ($condition as $column => $value) {
-			$column = Helpers::escape($driver, $column, dibi::IDENTIFIER);
+			$column = Helpers::escape($driver, $column, Fluent::Identifier);
 
 			if ($filter->isExactSearch()) {
 				$this->dataSource->where(sprintf('%s = %%s', $column), $value);

diff --git a/src/DataSource/DibiFluentMssqlDataSource.php b/src/DataSource/DibiFluentMssqlDataSource.php
@@ -7,7 +7,6 @@
 use Contributte\Datagrid\Filter\FilterDateRange;
 use Contributte\Datagrid\Filter\FilterText;
 use Contributte\Datagrid\Utils\DateTimeHelper;
-use dibi;
 use Dibi\Fluent;
 use Dibi\Helpers;
 use Dibi\Result;
@@ -108,7 +107,7 @@ protected function applyFilterText(FilterText $filter): void
 		$or = [];
 
 		foreach ($condition as $column => $value) {
-			$column = Helpers::escape($driver, $column, dibi::IDENTIFIER);
+			$column = Helpers::escape($driver, $column, Fluent::Identifier);
 
 			if ($filter->isExactSearch()) {
 				$this->dataSource->where(sprintf('%s = %%s', $column), $value);