Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed datagrid table data-attribue, fixed CSS #1104

Merged
merged 4 commits into from
Nov 3, 2023
Merged

Fixed datagrid table data-attribue, fixed CSS #1104

merged 4 commits into from
Nov 3, 2023

Conversation

paveljanda
Copy link
Member

@paveljanda paveljanda commented Nov 2, 2023 •
edited
Loading

Previously, datagrid was using:

class="datagrid datagrid-{$control->getFullName()}"

In the next branch, it was change to:

data-datagrid-{$control->getFullName()}

even though I think the intentions was different. The MR makes it so:

data-datagrid-name="{$control->getFullName()}"

Also, all CSS was fixed.

@paveljanda paveljanda changed the base branch from master to next November 2, 2023 12:51
@paveljanda paveljanda merged commit 9a74127 into next Nov 3, 2023
15 checks passed
@f3l1x f3l1x deleted the next-fix-css branch May 3, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@paveljanda