Skip to content

Commit

Permalink
Set main attribute in headless package.json back to the dist file
Browse files Browse the repository at this point in the history
Otherwise the prod webpack build is built in a different way so that:

1. runtime object assignments (e.g. `Object.assign(api, foo)`) aren't
reflected on imported objects (causing undefined attribute errors).
2. circular imports cause crashes, making the build unusable.

Unfortunately fixing these issues on a more fundamental level will
require much more work.
  • Loading branch information
jcbrand committed Sep 28, 2023
1 parent 11934b3 commit 292ce34
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions src/headless/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,7 @@
],
"homepage": "https://conversejs.org",
"license": "MPL-2.0",
"main": "index.js",
"browser": "dist/converse-headless.js",
"main": "dist/converse-headless.js",
"module": "index.js",
"keywords": [
"converse.js",
Expand Down

0 comments on commit 292ce34

Please sign in to comment.