Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes in overlayed mode overflow issue in chat box in home page #3272

Closed

Conversation

love-sonkar
Copy link

Fixes #3133 issue changes overflow-y to none

Thanks for making a pull request to converse.js!

Before submitting your request, please make sure the following conditions are met:

  • [Y] Add a changelog entry for your change in CHANGES.md
  • [Y] When adding a configuration variable, please make sure to
    document it in docs/source/configuration.rst
  • [Y] Please add a test for your change. Tests can be run in the commandline
    with make check or you can run them in the browser by running make serve
    and then opening http://localhost:8000/tests.html.

CHANGES.md Outdated Show resolved Hide resolved
Copy link
Member

@jcbrand jcbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your pull request. I've left some review comments.

@@ -53,6 +53,7 @@
#controlbox {
order: -1;
color: var(--controlbox-text-color);
overflow-y:none;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is none a valid value?

It's not shown here as one: https://developer.mozilla.org/en-US/docs/Web/CSS/overflow-y

What's the effect of this? Does it disable vertical scrolling in the controlbox?
If so, I'm not convinced that this is the right solution, since the controlbox might go off-screen on certain displays.

Did you check what happens in fullscreen mode? Might be that this bug should only be fixed for overlayed view mode, in which case you need to put any CSS changes under the following:

.conversejs {
    converse-chats {
        &.converse-overlayed {
            #controlbox {

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah it's valid value it's work like hidden property but i can changes to the hidden for convinence,

i found a one more thing while checking the chat box there is a dragabble property, and we can resize the chat box but we should stop the resize property to a specific height so we can set the flyout min-height to 500px so that when user try to resize this to 400px it won't be an we can't see any scrollbar this is my approch to solve this bug.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i can changes to the hidden for convinence

Yes, hidden would be better.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've thought about this some more, and I don't think this is the right solution.

You're simply disabling scrolling, which means that if the contents would overflow, it would be invisible and the user cannot scroll to see it.

Also, since I don't know where those icons reported in #3133 come from, it's not clear to me what needs to be fixed, how it should be done or whether there really is anything to fix.

src/plugins/controlbox/styles/controlbox-head.scss Outdated Show resolved Hide resolved
@love-sonkar
Copy link
Author

hey sir i have fixed the issue as you told me

@jcbrand jcbrand closed this Oct 3, 2023
@jcbrand
Copy link
Member

jcbrand commented Oct 3, 2023

Closing based on #3272 (comment)

Thanks for the effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In overlayed mode the input form icons scroll with the page
2 participants