Fix emojis vs uppercase letters: #3501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JohnXLivingston
commented
Sep 6, 2024
JohnXLivingston
commented
- Fix: trying to use an emojis with an uppercase letter breaks the message field.
- Fix: isOnlyEmojis vs uppercase letters.
- Fix: renaming getEmojisByAtrribute to getEmojisByAttribute.
* Fix: trying to use an emojis with an uppercase letter breaks the message field. * Fix: isOnlyEmojis vs uppercase letters. * Fix: renaming getEmojisByAtrribute to getEmojisByAttribute.
JohnXLivingston
added a commit
to JohnXLivingston/converse.js
that referenced
this pull request
Dec 5, 2024
… field. Previoux fix (conversejs#3501) was wrong and introduced other issues: * impossible to define an emoji with uppercase letters * possible to use an emoji 🔤 by using :Abc:, but it won't display So, the correct fix is just to remove the 'i' modifier for the shortname_regex, to always have case sensitive emojis.
JohnXLivingston
added a commit
to JohnXLivingston/converse.js
that referenced
this pull request
Dec 5, 2024
… field. Previoux fix (conversejs#3501) was wrong and introduced other issues: * impossible to define an emoji with uppercase letters * possible to use an emoji 🔤 by using :Abc:, but it won't display So, the correct fix is just to remove the 'i' modifier for the shortname_regex, to always have case sensitive emojis.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.