Updates #2586: Add support for XEP-0402 Bookmarks #3562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcbrand
force-pushed
the
jcbrand/xep-402
branch
4 times, most recently
from
8c8648d to
1936790
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
jcbrand
force-pushed
the
jcbrand/xep-402
branch
2 times, most recently
from
3164eb2 to
975eca8
Compare
|
|
||
| const { Strophe, $iq, sizzle } = converse.env; | ||
|
|
||
| const { Strophe, sizzle, stx } = converse.env; |
Check notice
Code scanning / CodeQL
Unused variable, import, function or class Note
jcbrand
force-pushed
the
jcbrand/xep-402
branch
from
975eca8 to
101ebeb
Compare
jcbrand
force-pushed
the
jcbrand/xep-402
branch
2 times, most recently
from
3cd1028 to
a825314
Compare
jcbrand
force-pushed
the
jcbrand/xep-402
branch
from
90074f9 to
9547669
Compare
To bring it in line with other chat boxes.
jcbrand
force-pushed
the
jcbrand/xep-402
branch
from
9547669 to
b2eb463
Compare
- Update to latest Strophe.js - Add support for setting the password in the bookmark - Add more explicit parsing of bookmarks from a stanza - Save and include the `<extensions>` element in outgoing bookmark stanzas
jcbrand
force-pushed
the
jcbrand/xep-402
branch
from
0d371ad to
e8f3ed7
Compare
- Turn it into a folder - Use the stx tagged template literal
jcbrand
force-pushed
the
jcbrand/xep-402
branch
from
e8f3ed7 to
4e4db7d
Compare
jcbrand
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.