Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cxl-ui): action bar position #203

Closed
wants to merge 1 commit into from
Closed

fix(cxl-ui): action bar position #203

wants to merge 1 commit into from

Conversation

anoblet
Copy link
Collaborator

@anoblet anoblet commented Apr 18, 2022 •
edited by lkraav
Loading

Fix the position of the action bar so that it is along the bottom of the viewport.

image

Delete .entry-content element from any lesson content.

@anoblet
fix(cxl-ui): action-bar position
9b6055f 
Position the action-bar at the bottom of the viewport
@github-actions
Copy link

size-limit report 📦

Path Size
packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js, packages/cxl-ui/pkg/dist-web/cxl-ui.js 41.4 KB (-0.02% 🔽)

@lkraav
Copy link

lkraav commented Apr 18, 2022

Now I remember why sticky: go test absolute on longer content, like https://cxl.com/institute/lesson/how-to-find-the-community-sweet-spot/

image

@lkraav
Copy link

lkraav commented Feb 11, 2023

/rebase

@lkraav
Copy link

lkraav commented Feb 11, 2023

I updated opener with problem statement screenshot.

@lkraav lkraav mentioned this pull request Apr 25, 2023
Open
@lkraav
Copy link

lkraav commented Apr 25, 2023

Close in favor of #275.

@lkraav lkraav closed this Apr 25, 2023
@lkraav lkraav deleted the anoblet-patch-1 branch April 25, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anoblet @lkraav