Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leho optimize cxl-app-layout stories, fix #269 #270

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

lkraav
Copy link

@lkraav lkraav commented Mar 23, 2023

@paulkirspuu you can rebase your branch on this already.

@github-actions
Copy link

github-actions bot commented Mar 23, 2023

size-limit report 📦

Path Size
packages/cxl-ui/pkg/dist-web/cxl-ui.js 33.69 KB (+0.37% 🔺)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js 11.87 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js 24.9 KB (0%)
packages/cxl-ui/pkg/dist-web/vendor.js 125.63 KB (+0.03% 🔺)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js, packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js, packages/cxl-ui/pkg/dist-web/cxl-ui.js, packages/cxl-ui/pkg/dist-web/manifest.js, packages/cxl-ui/pkg/dist-web/unresolved.js, packages/cxl-ui/pkg/dist-web/vendor.js 197.25 KB (+0.08% 🔺)

@lkraav lkraav self-assigned this Mar 23, 2023
@lkraav
Copy link
Author

lkraav commented Mar 23, 2023

OK rebase, and use the new partial now @paulkirspuu.

@lkraav lkraav changed the title Leho optimize cxl-app-layout stories Leho optimize cxl-app-layout stories, fix #269 Mar 23, 2023
@lkraav lkraav linked an issue Mar 23, 2023 that may be closed by this pull request
@lkraav lkraav requested a review from a team March 24, 2023 13:39
@lkraav lkraav force-pushed the leho-optimize-cxl-app-layout-stories branch from e227afb to 64c78cd Compare March 24, 2023 18:53
@lkraav lkraav force-pushed the leho-optimize-cxl-app-layout-stories branch from 64c78cd to b266700 Compare March 24, 2023 19:36
Copy link
Author

@lkraav lkraav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More bugs fixed, should be gtg now.

@lkraav lkraav force-pushed the leho-optimize-cxl-app-layout-stories branch from b266700 to 4dca853 Compare March 25, 2023 12:44
@lkraav
Copy link
Author

lkraav commented Mar 25, 2023

Significant story architecture upgrade, this is SB7-ready now. Rebase again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor(storybook): optimize cxl-app-layout story structure
1 participant