-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cxl-ui): [cxl-marketing-nav] add scroll indicator for large menus #277
base: master
Are you sure you want to change the base?
Conversation
size-limit report 📦
|
ee5534b
to
ea065ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anoblet it'd be useful to have screenshot here, so I created one:
Proposed scroll indicator is too heavy. It should be something lightweight. Take a look at the horizontal cue we have for menus:
White gradient background with an arrow would be better.
@pawelkmpt Updated |
Looks better. Can we make it clickable like horizontal menu cues are? |
@pawelkmpt Updated |
I tested and when I get to the end of the list cue disappears in weird way making scrollbar smaller. It makes an impression of all elements jumping. https://www.loom.com/share/bf9c27ac14e540e7b0d75bfb7aa3d80f Can we do sth about it? |
Another "Should this even be done" discussion https://app.clickup.com/t/861mkj72q?comment=90040011549686 |
@pawelkmpt I wasn't sure if it was more confusing to keep the scroll indicator once the user reached the bottom or not. I've updated this PR to keep the scroll indicator. |
@anoblet I tested and it still has weird feeling because it's permanently visible there and clickable even if there's no more items at the and. Ideally it should:
I'd try to achieve it with Is it doable with components setup we have? |
Clickup: https://app.clickup.com/t/861mkj72q
Previous PR: #274