Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Vaadin #320

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Upgrade Vaadin #320

wants to merge 2 commits into from

Conversation

anoblet
Copy link
Collaborator

@anoblet anoblet commented Sep 8, 2023

No description provided.

@anoblet anoblet requested a review from a team September 8, 2023 10:57
@github-actions
Copy link

github-actions bot commented Sep 8, 2023

size-limit report 📦

Path Size
packages/cxl-ui/pkg/dist-web/cxl-ui.js 61.53 KB (-0.1% 🔽)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js 11.87 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js 27.11 KB (-0.01% 🔽)
packages/cxl-ui/pkg/dist-web/vendor.js 135.75 KB (+0.13% 🔺)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js, packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js, packages/cxl-ui/pkg/dist-web/cxl-ui.js, packages/cxl-ui/pkg/dist-web/manifest.js, packages/cxl-ui/pkg/dist-web/unresolved.js, packages/cxl-ui/pkg/dist-web/vendor.js 237.41 KB (+0.05% 🔺)

@lkraav
Copy link

lkraav commented Sep 8, 2023

Hmm, I was thinking maybe v23 latest point release is safer, but I think we can also evaluate now whether everything still works in v24?

I remember I had some breaking changes concerns, but can't recall exactly what they were 🤔 we need to investigate v24 changelog.

@anoblet
Copy link
Collaborator Author

anoblet commented Sep 8, 2023

Taking smaller steps would probably be better. I'm curious, running yarn upgrade-interactive --scope '@vaadin' only updates package-lock.json and not package.json. Is this something we're comfortable with? It feels a bit unnatural to search and replace package versions for no effect.

@lkraav
Copy link

lkraav commented Sep 11, 2023

I'm curious, running yarn upgrade-interactive --scope '@vaadin' only updates package-lock.json and not package.json. Is this something we're comfortable with? It feels a bit unnatural to search and replace package versions for no effect.

This is referring to minor version upgrade? If constraints listed in package.json remains valid, I don't see a problem. What yarn version are you working with? This behavior may have changed over time?

@anoblet anoblet force-pushed the anoblet/feat/vaadin branch from 976237d to d09ce3a Compare September 12, 2023 23:59
@anoblet
Copy link
Collaborator Author

anoblet commented Sep 13, 2023

This is referring to a minor upgrade. I'm using the latest version of yarn (1.22.19), and this looks to be expected behavior: https://dev.to/wgao19/why-running-yarn-upgrade-does-not-update-my-package-json-3mon

It's a bit confusing, though I don't see a need to update constraints.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants