Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update icons #10

Merged
merged 2 commits into from
Oct 10, 2024
Merged

feat: update icons #10

merged 2 commits into from
Oct 10, 2024

Conversation

anoblet
Copy link
Collaborator

@anoblet anoblet commented Oct 8, 2024

https://app.clickup.com/t/86b2een91

Description

This PR solves # .

Steps completed:

According to our definition of done, I have completed the following steps:

  • Acceptance criteria met
  • Unit tests added
  • Docs updated (including config and env variables)
  • Translations added
  • UX tested
  • Browsers / platforms tested
  • Rebased & ready to merge without conflicts
  • Reviewed own code

@anoblet anoblet requested review from lkraav and pawelkmpt October 8, 2024 12:46
Copy link

@pawelkmpt pawelkmpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about app name?

@anoblet anoblet requested a review from pawelkmpt October 8, 2024 16:22
@anoblet
Copy link
Collaborator Author

anoblet commented Oct 8, 2024

I updated app name, and app short name. What do we want to put for app description?

Copy link

@pawelkmpt pawelkmpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I deployed live. Icons are good. App name is still "JW OTT Webapp". Does new name work for you locally?

@anoblet
Copy link
Collaborator Author

anoblet commented Oct 9, 2024

Strange. It works locally, though when building it does not. I've tried setting up a production .env file, though they do not seem to take effect. I've tried: .env.prod, .env.prod.local, .env.production, .env.production.local.

Edit:

Reference:

@pawelkmpt
Copy link

Strange. It works locally, though when building it does not. I've tried setting up a production .env file, though they do not seem to take effect. I've tried: .env.prod, .env.prod.local, .env.production, .env.production.local.

If you don't find a solution in 1h please just hardcode our strings and leave the comment in .env file

@anoblet anoblet force-pushed the anoblet/feat/icons branch from 21e7ddb to 6da5415 Compare October 9, 2024 22:13
@anoblet anoblet requested a review from pawelkmpt October 9, 2024 22:17
@pawelkmpt pawelkmpt merged commit ba988f1 into cxl-main Oct 10, 2024
3 of 5 checks passed
@pawelkmpt pawelkmpt deleted the anoblet/feat/icons branch October 10, 2024 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants