-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update icons #10
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about app name?
I updated app name, and app short name. What do we want to put for app description? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I deployed live. Icons are good. App name is still "JW OTT Webapp". Does new name work for you locally?
Strange. It works locally, though when building it does not. I've tried setting up a production .env file, though they do not seem to take effect. I've tried: .env.prod, .env.prod.local, .env.production, .env.production.local. Edit: Reference: |
If you don't find a solution in 1h please just hardcode our strings and leave the comment in |
21e7ddb
to
6da5415
Compare
6da5415
to
0c6eacf
Compare
https://app.clickup.com/t/86b2een91
Description
This PR solves # .
Steps completed:
According to our definition of done, I have completed the following steps: