Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: redirect /cxl-sso to https://cxl.com/institute/oauth/authorize #11

Closed
wants to merge 1 commit into from

Conversation

anoblet
Copy link
Collaborator

@anoblet anoblet commented Oct 14, 2024

https://app.clickup.com/t/86b2gjwmu

Description

This PR solves # .

Steps completed:

According to our definition of done, I have completed the following steps:

  • Acceptance criteria met
  • Unit tests added
  • Docs updated (including config and env variables)
  • Translations added
  • UX tested
  • Browsers / platforms tested
  • Rebased & ready to merge without conflicts
  • Reviewed own code

@anoblet anoblet requested review from lkraav and pawelkmpt October 14, 2024 17:33
@anoblet
Copy link
Collaborator Author

anoblet commented Oct 14, 2024

It's not very elegant, though doing it elsewhere in the app would take a long time to load.

Edit:
I tried Firebase rewrite, Vite server proxy, and React Router Dom, none of which supported an external redirect with params without eventually using this code.

Copy link

@pawelkmpt pawelkmpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have misunderstanding here :( It was not suppose to just redirect URL but get all params generated by getOAuthConfig and then redirect.

I didn't write explicitly to use this function (?) in the ClickUp description but thought "all necessary params" and "same kind of redirect" explain my goal.

@pawelkmpt
Copy link

See #12

@pawelkmpt pawelkmpt closed this Oct 18, 2024
@pawelkmpt pawelkmpt deleted the anoblet/feat/redirect branch October 18, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants