Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: switch to montserrat for all fonts #15

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

anoblet
Copy link
Collaborator

@anoblet anoblet commented Nov 5, 2024

https://app.clickup.com/t/86b2pt9td

Description

This PR solves # .

Steps completed:

According to our definition of done, I have completed the following steps:

  • Acceptance criteria met
  • Unit tests added
  • Docs updated (including config and env variables)
  • Translations added
  • UX tested
  • Browsers / platforms tested
  • Rebased & ready to merge without conflicts
  • Reviewed own code

@anoblet anoblet requested review from lkraav and pawelkmpt November 5, 2024 15:25
@anoblet anoblet self-assigned this Nov 5, 2024
@@ -1,5 +1,7 @@
@use 'variables';

@import url('https://fonts.googleapis.com/css2?family=Dancing+Script:[email protected]&family=Montserrat:ital,wght@0,100..900;1,100..900&display=swap');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Dancing Script is not necessary here

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops! I included the wrong font. This is fixed.

@anoblet anoblet force-pushed the anoblet/feat/typography branch from fad925f to 8b5f6e8 Compare November 6, 2024 12:11
@anoblet anoblet requested a review from pawelkmpt November 6, 2024 12:12
@pawelkmpt pawelkmpt merged commit 8de93df into cxl-main Nov 7, 2024
3 of 5 checks passed
@pawelkmpt pawelkmpt deleted the anoblet/feat/typography branch November 7, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants