-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP]: E2E Test - Processing #159
base: master
Are you sure you want to change the base?
Conversation
The test case is changed now. Earlier test case contained a single object of different intensities which is not a supported feature at present. Cross module test across Processing/Server/Networking is working now. |
Processing was tested very extensively at L2. |
@muhammedyaseen-git Any updates? |
I will not be able to give content E2E testbdue to time constraints now. |
Okay, can we add more tests for processing? We have so many features and it will be better if we can cover as many as we can in E2E. |
// IP of main server verified by running MainServer.jar separately | ||
String ip = "192.168.1.6"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a dynamic IP address (changes from time to time and depends totally upon the DHCP on your local network). High chances that your system might have lost this IP (and received something else from the DHCP) and the test won't work on your system locally as well. Needless to say, it won't work on mine.
You need to figure out a way to get the IP dynamically to get these tests running.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there's no other better way you find, I suggest keeping IP
as a command-line argument.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use getIP of networking to get the IP of your machine. As main server and client will be running on same machine for this test it's fine.
Please write in the description about what modules these E2E tests comprise of (processing here), and which mode of networking (LAN here), and the features that have been tested. |
E2E test for the project.
Thanks to @tymefighter and @sahul343 for helping with the respective module details.