-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
client: Add wasm support #2692
base: master
Are you sure you want to change the base?
client: Add wasm support #2692
Conversation
@Aursen is attempting to deploy a commit to the coral-xyz Team on Vercel. A member of the Team first needs to authorize it. |
The import error makes sense as we don't have
It's still strange that running The errors about
Will push a fix for |
…ersions * Enable `MessageEvent` feature of `web-sys`. The crate works without `MessageEvent` feature enabled in the repo but not with the published version as revealed in coral-xyz/anchor#2692 * Update Solana crates to `1.17.4` * Update `wasm-bindgen` to `0.2.88` and other related crates to the latest
Are you still interested in working on this? The main reason this hasn't been merged yet is because I wanted to check if we can decouple the WASM impl to reduce the complexity a bit. |
imho, having a single standalone crate is much better than having two separate crates and letting the compiler decide which one to enable. It also reduces the carbon footprint because you only need to host one crate on crate.io. |
Yeah let met finish this one |
By "decouple" I meant moving the impl to a different file or folder similar to |
That makes sense! At first, I thought you meant to split it into two separate crates. |
Hey, @Aursen! It would be great if you could add a function to return the transaction without sending it by the client. I want the browser's wallet extension to handle signing and sending the transaction. If you can add this feature, that would be awesome! |
Problem
Currently, the anchor client cannot compile or be used in wasm.
Summary of changes