Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VTX-4075: make one method public and clippy happy #223

Open
wants to merge 27 commits into
base: v33
Choose a base branch
from
Open

VTX-4075: make one method public and clippy happy #223

wants to merge 27 commits into from

Conversation

fsdvh
Copy link
Collaborator

@fsdvh fsdvh commented Jan 25, 2024 •
edited
Loading

Added sort_expr to display for ProjectionExec and UnionExec. I need to reuse spawn_buffered in ballista

@github-actions github-actions bot added the core label Jan 25, 2024
@fsdvh fsdvh changed the title VTX-4075: ore verbose display for union VTX-4075: more verbose display for union Jan 25, 2024
@fsdvh fsdvh changed the title VTX-4075: more verbose display for union VTX-4075: for info in display Jan 25, 2024
@fsdvh fsdvh changed the title VTX-4075: for info in display VTX-4075: more info in display Jan 25, 2024
thinkharderdev
thinkharderdev reviewed Jan 26, 2024
View reviewed changes
Copy link
Collaborator

@thinkharderdev thinkharderdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for now, but need to make sure this is acceptable to upstream (changes to display especially).

@fsdvh fsdvh changed the title VTX-4075: more info in display VTX-4075: make one method public Jan 26, 2024
@fsdvh fsdvh changed the title VTX-4075: make one method public VTX-4075: make one method public and clip Jan 26, 2024
@fsdvh fsdvh changed the title VTX-4075: make one method public and clip VTX-4075: make one method public and clippy Jan 26, 2024
@fsdvh fsdvh changed the title VTX-4075: make one method public and clippy VTX-4075: make one method public and clippy happy Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkharderdev thinkharderdev thinkharderdev approved these changes

@cprieto cprieto cprieto approved these changes

Assignees
No one assigned
Labels
core optimizer physical-expr sqllogictest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fsdvh @cprieto @thinkharderdev