Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test for s3_key folder #12

Merged
merged 3 commits into from
Dec 27, 2023
Merged

test for s3_key folder #12

merged 3 commits into from
Dec 27, 2023

Conversation

juan-coralogix
Copy link
Collaborator

Description

Added Tests:
test_dynamic_folder_app_name
test_dynamic_folder_app_name_fails
Fixes #

How Has This Been Tested?

locally

Checklist:

  • I have updated the versions in the SemanticVersion in template.yaml
  • I have updated the CHANGELOG.md
  • I have created necessary PR to Terraform Module Repository (https://github.com/coralogix/terraform-coralogix-aws) if needed
  • This change does not affect any particular component (e.g. it's CI or docs change)

@juan-coralogix juan-coralogix requested review from a team as code owners December 26, 2023 20:10
@juan-coralogix juan-coralogix added the skip-changelog Skip changelog update check label Dec 26, 2023
@royfur royfur removed request for a team December 27, 2023 14:09
daidokoro
daidokoro approved these changes Dec 27, 2023
View reviewed changes
Copy link
Contributor

@daidokoro daidokoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daidokoro daidokoro merged commit caeebfb into master Dec 27, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daidokoro daidokoro daidokoro approved these changes

Assignees
No one assigned
Labels
skip-changelog Skip changelog update check
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juan-coralogix @daidokoro