Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cds-1705 Enhance Metadata collection and dynamic allocation for App/Subsystem Name #121

Merged
merged 22 commits into from
Dec 12, 2024

Conversation

daidokoro
Copy link
Contributor

@daidokoro daidokoro commented Dec 10, 2024

This PR enhances the metadata collection capabilities of the shipper. Metadata is now collected from all available integrations internally and can be added using the AddMetadata parameter of the integration.

Dynamic Value allocation syntax has been updated and enhanced allowing for the use of regular expressions to parse available metadata values while setting subsystem and application name values.

{{ metadata | r'regex' }}
  • added metadata context type
  • implemented metadataContext type to handle metadata cross functinos and threads
  • cargo
  • updated JSONMessage type with new attribute names, added support functions to struct
  • added additoinal metadata for sqs, ecr and kinesis events
  • udpatd test
  • modified metadata key names and updated MetadataContext struct
  • fixed dynamic metadata replacement syntax
  • add tests for metadataContext evaluation
  • removed headers from LogExporterConfig as the option has been removed in upstream sdk
  • added MetadataContext method to handle dynamic metadata allocation and removed old tests
  • cargo update
  • changelog
  • updated README
  • adjusted metadata name for s3.key to s3.object.key
  • template version bump
  • version bump

Important

This PR contains breaking changes

Description

Fixes #

How Has This Been Tested?

Checklist:

  • I have updated the versions in the SemanticVersion in template.yaml
  • I have updated the CHANGELOG.md
  • I have created necessary PR to Terraform Module Repository (https://github.com/coralogix/terraform-coralogix-aws) if needed
  • This change does not affect any particular component (e.g. it's CI or docs change)

@daidokoro daidokoro requested a review from a team as a code owner December 10, 2024 21:36
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/logs/mod.rs Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
@daidokoro
Copy link
Contributor Author

Thanks for the review @RafalSumislawski, I've fixed all the items you've pointed out. Let me know if you spot anything else.

@daidokoro daidokoro merged commit 4a64ad3 into master Dec 12, 2024
10 checks passed
@daidokoro daidokoro deleted the cds-1705 branch December 12, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants