-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cds-1705 Enhance Metadata collection and dynamic allocation for App/Subsystem Name #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d removed old tests
RafalSumislawski
approved these changes
Dec 11, 2024
Thanks for the review @RafalSumislawski, I've fixed all the items you've pointed out. Let me know if you spot anything else. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the metadata collection capabilities of the shipper. Metadata is now collected from all available integrations internally and can be added using the AddMetadata parameter of the integration.
Dynamic Value allocation syntax has been updated and enhanced allowing for the use of regular expressions to parse available metadata values while setting subsystem and application name values.
Important
This PR contains breaking changes
Description
Fixes #How Has This Been Tested?
Checklist: