Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow log groups with / to trigger lambda [CDS-1191] #89

Merged
merged 6 commits into from
Apr 25, 2024

Conversation

guyrenny
Copy link
Contributor

@guyrenny guyrenny commented Apr 25, 2024

Description

StatementId dose not allow text with / so add replace function to replace all / with -

Add a new parameter to allow users

How Has This Been Tested?

Checklist:

  • I have updated the versions in the SemanticVersion in template.yaml
  • I have updated the CHANGELOG.md
  • I have created necessary PR to Terraform Module Repository (https://github.com/coralogix/terraform-coralogix-aws) if needed
  • This change does not affect any particular component (e.g. it's CI or docs change)

@guyrenny guyrenny requested a review from a team as a code owner April 25, 2024 05:20
Copy link
Collaborator

@juan-coralogix juan-coralogix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran our tests:

E2E Tests ----> Ok
Unit Tests ----> Ok

Looks good !

@guyrenny guyrenny merged commit 873f6b9 into master Apr 25, 2024
12 checks passed
@guyrenny guyrenny deleted the cloudwatch-bug-fix branch April 25, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants