fix: decouple IAM policy documents from IAM role resource #196
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #193
additionally decouples
assume_role_policy
from IAM role specifications to the separatedata.aws_iam_policy_document
resourceHow Has This Been Tested?
terraform apply
before the code change to reproduce this warning:terraform plan
onfirehose-logs
module instance after the code changeterraform apply
to see the warning is gone and the new resource has been added without breaking the resource permissionAlthough terraform will technically create a new resource, practically the state of IAM role altogether with its policy will stay the same as it was before the change: same inline policy format, same name, same permissions. (during
tf apply
it won't return you the error that this policy already exists)Checklist: