-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds action to update dependencies. #18
base: main
Are you sure you want to change the base?
Conversation
# deprecated. see https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ | ||
#run: echo "::set-output name=changed::$(git status --porcelain | wc -l)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# deprecated. see https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ | |
#run: echo "::set-output name=changed::$(git status --porcelain | wc -l)" |
Do we need to add this deprecated command and note on a newly created code?
#run: echo "::set-output name=changed::$(git status --porcelain | wc -l)" | ||
run: echo "changed=$(git status --porcelain | wc -l)" >> $GITHUB_OUTPUT | ||
|
||
- uses: stefanzweifel/git-auto-commit-action@v5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Am I missing something, or do you wish to skip opening a PR? If so, mixed feelings here, the import code should be okay, but even a self-approval while taking a quick look at the changes might be better than just pushing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A legit question but what would that double check be? also, who performs it? I think what we could probably do is to make coraza parse the entire ruleset. Thoughts @anuraaga ?
Why not just use renovatebot here? |
This PR adds an action to manually trigger the update of CRS or Coraza.