Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow selectors on *_NAMES collections #1143

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

add test for getting non-existing item from named collection

f8e778f
Select commit
Loading
Failed to load commit list.
Open

feat: allow selectors on *_NAMES collections #1143

add test for getting non-existing item from named collection
f8e778f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Nov 7, 2024 in 0s

59.37% of diff hit (target 82.72%)

View this Pull Request on Codecov

59.37% of diff hit (target 82.72%)

Annotations

Check warning on line 140 in internal/collections/named.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/collections/named.go#L139-L140 

Added lines #L139 - L140 were not covered by tests

Check warning on line 578 in internal/corazawaf/transaction.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/corazawaf/transaction.go#L577-L578 

Added lines #L577 - L578 were not covered by tests

Check warning on line 585 in internal/corazawaf/transaction.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/corazawaf/transaction.go#L584-L585 

Added lines #L584 - L585 were not covered by tests

Check warning on line 1995 in internal/corazawaf/transaction.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/corazawaf/transaction.go#L1995 

Added line #L1995 was not covered by tests

Check warning on line 2019 in internal/corazawaf/transaction.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/corazawaf/transaction.go#L2019 

Added line #L2019 was not covered by tests

Check warning on line 2027 in internal/corazawaf/transaction.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/corazawaf/transaction.go#L2027 

Added line #L2027 was not covered by tests

Check warning on line 2031 in internal/corazawaf/transaction.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/corazawaf/transaction.go#L2031 

Added line #L2031 was not covered by tests

Check warning on line 2051 in internal/corazawaf/transaction.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/corazawaf/transaction.go#L2051 

Added line #L2051 was not covered by tests

Check warning on line 2055 in internal/corazawaf/transaction.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/corazawaf/transaction.go#L2055 

Added line #L2055 was not covered by tests

Check warning on line 2059 in internal/corazawaf/transaction.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/corazawaf/transaction.go#L2059 

Added line #L2059 was not covered by tests

Check warning on line 221 in internal/variables/variablesmap.gen.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/variables/variablesmap.gen.go#L218-L221 

Added lines #L218 - L221 were not covered by tests

Check warning on line 233 in internal/variables/variablesmap.gen.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/variables/variablesmap.gen.go#L228-L233 

Added lines #L228 - L233 were not covered by tests

Check warning on line 245 in internal/variables/variablesmap.gen.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/variables/variablesmap.gen.go#L240-L245 

Added lines #L240 - L245 were not covered by tests

Check warning on line 249 in internal/variables/variablesmap.gen.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/variables/variablesmap.gen.go#L248-L249 

Added lines #L248 - L249 were not covered by tests

Check warning on line 253 in internal/variables/variablesmap.gen.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/variables/variablesmap.gen.go#L252-L253 

Added lines #L252 - L253 were not covered by tests

Check warning on line 263 in internal/variables/variablesmap.gen.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/variables/variablesmap.gen.go#L258-L263 

Added lines #L258 - L263 were not covered by tests
View more details on Codecov