-
-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add https audit log support #826
Conversation
Unfortunatelly we can't do bathing as we can't close the exporter (WAF does not support close method and hence when terminating the APP the batched requests will be lost). I think it is a good idea to add a Close method now but not to force people to use it and maybe the exporter can listen to termination signal cc @anuraaga ? |
Decisions we made during meeting https://owasp.slack.com/archives/C02BXH135AT/p1687955362171029 |
Any movement @jptosso? |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #826 +/- ##
==========================================
- Coverage 81.57% 81.56% -0.01%
==========================================
Files 158 159 +1
Lines 8959 9000 +41
==========================================
+ Hits 7308 7341 +33
- Misses 1406 1412 +6
- Partials 245 247 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
"github.com/corazawaf/coraza/v3/experimental/plugins/plugintypes" | ||
) | ||
|
||
// httpsWriter is used to store logs in a single file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// httpsWriter is used to store logs in a single file | |
// httpsWriter sends logs to an HTTP endpoint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also include this please
One thing missing here is the content type support. We could add it to formatters (yet not to the interface) and do interface assertion ok init and record the value to be added to the requests. |
I will take care before v3.0.3 release |
Following discussion #813, implements HTTPS audit log writer
Coraza v4 should consider improvements on this, like additional settings