Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fixes audit log. #889

Merged
merged 4 commits into from
Nov 13, 2023
Merged

chore: fixes audit log. #889

merged 4 commits into from
Nov 13, 2023

Conversation

jcchavezs
Copy link
Member

Thank you for contributing to Coraza WAF, your effort is greatly appreciated
Before submitting check if what you want to add to coraza list meets quality standards before sending pull request. Thanks!

Make sure that you've checked the boxes below before you submit PR:

Thanks for your contribution ❤️

Copy link
Member

@M4tteoP M4tteoP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! And, as you mentioned offline, adding tests will be even greater.

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Files Coverage Δ
internal/auditlog/concurrent_writer.go 85.24% <100.00%> (+5.93%) ⬆️
internal/corazawaf/waf.go 88.23% <ø> (ø)
waf.go 82.89% <100.00%> (+17.18%) ⬆️
internal/auditlog/serial_writer.go 82.85% <0.00%> (-7.77%) ⬇️
internal/auditlog/formats.go 89.61% <50.00%> (-10.39%) ⬇️

📢 Thoughts on this report? Let us know!

@jcchavezs jcchavezs marked this pull request as ready for review November 13, 2023 09:32
@jcchavezs jcchavezs requested a review from a team as a code owner November 13, 2023 09:32
@jcchavezs jcchavezs merged commit 48cf923 into main Nov 13, 2023
8 checks passed
@jcchavezs jcchavezs deleted the fixes_audit_log branch November 13, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants