Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADCIO-2798) chore: chore preview yml #12

Merged
merged 4 commits into from
Mar 14, 2024
Merged

Conversation

dev-redo
Copy link
Contributor

@dev-redo dev-redo commented Mar 14, 2024

✅ Jira Ticket Number

♻️ Current situation

preview.yml의 runner가 self-hosted로 되어 있어서 액션이 동작하지 않았습니다.

관련 논의 슬랙 링크 - https://corcaai.slack.com/archives/C062A2RFTS6/p1710306705784469

💡 Proposed solution

  • runner를 ubuntu-latest로 바꾸었습니다.
  • 스토리북을 빌드하는 step을 추가해주었습니다.

⚙️ Release Notes

➕ Additional Information

🧪 Testing

🧑‍💻 Reviewer Nudging

✅ Checklist

  • 수정 사항에 대한 테스트를 마쳤습니다.
  • 백엔드 수정 사항이 있는 경우, gen-api 를 통해 API 클라이언트 코드를 재생성하였습니다.
  • 관련 노션 문서를 업데이트하였습니다.
  • 프론트엔드 번역 작업시, trans-download 를 통해 구글스프레드시트의 번역을 다운로드받았습니다.

@dev-redo dev-redo changed the title chore: chore preview yml NONE) chore: chore preview yml Mar 14, 2024
Copy link

🚀 Storybook Preview deployed at: https://cds-bmt1oju2v-corca.vercel.app

@dev-redo
Copy link
Contributor Author

dev-redo commented Mar 14, 2024

빌드 진짜 빠르네요

@dev-redo dev-redo self-assigned this Mar 14, 2024
@dev-redo dev-redo added the operations Request to develop functions for operation label Mar 14, 2024
@dev-redo dev-redo marked this pull request as ready for review March 14, 2024 06:37
hanchchch
hanchchch previously approved these changes Mar 14, 2024
Copy link

🚀 Storybook Preview deployed at: https://cds-aip9zti6j-corca.vercel.app

@dev-redo dev-redo merged commit 53bf73a into main Mar 14, 2024
1 check passed
@dev-redo dev-redo deleted the chore/chore-preview-yml branch March 14, 2024 06:46
@dev-redo dev-redo changed the title NONE) chore: chore preview yml ADCIO-2798) chore: chore preview yml Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
operations Request to develop functions for operation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants