CORE-17471 - Apply indexing to frequently used columns of the db table utxo_transaction_output
#1275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins build for PR 1275 build 3 Build Successful: |
…e `utxo_transaction_output`
filipesoliveira
force-pushed
the
filipe.oliveira/CORE-17471
branch
from
51f052d to
7c916f6
Compare
|
#1270 has some related updates. |
relyafi
reviewed
Oct 5, 2023
There was a problem hiding this comment.
One minor comment regarding style. I think we need to review how we are defining changesets generally, but that is a broader question and I don't think we should tackle that as part of this PR.
The PR however does need a description and some test notes, to provide background to the change. I'm assuming we should be able to demonstrate the new indexes being used by running the SQL queries that utilise these indexes with EXPLAIN ANALYSE.
...a/src/main/resources/net/corda/db/schema/vnode-vault/migration/ledger-utxo-creation-v5.1.xml
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The token selection feature uses db queries frequently. Indexing the columns that are used by those queries will improve performance. This commit indexes the columns
token_type,token_issuer_hash,token_symbol, andtoken_notary_x500_namefrom tableutxo_transaction_output.DB query details for the token balance execution:
DB query details for the token selection execution:
