CORE-17476 Adding Corda worker RPC endpoints to API schema #1276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jujoramos
reviewed
Oct 5, 2023
Comment on lines
286
to
289
| public static final String CRYPTO_WORKER_RPC_ENDPOINT = "worker.rpc.endpoint.crypto"; | ||
| public static final String VERIFICATION_WORKER_RPC_ENDPOINT = "worker.rpc.endpoint.verification"; | ||
| public static final String UNIQUENESS_WORKER_RPC_ENDPOINT = "worker.rpc.endpoint.uniqueness"; | ||
| public static final String PERSISTENCE_WORKER_RPC_ENDPOINT = "worker.rpc.endpoint.persistence"; |
There was a problem hiding this comment.
Is this really RPC?, would it make sense to call it HTTP directly instead?.
ben-millar
force-pushed
the
bm/CORE-17476/rpc-endpoints
branch
from
aea211b to
745ce7a
Compare
ben-millar
force-pushed
the
bm/CORE-17476/rpc-endpoints
branch
from
e509339 to
888b48f
Compare
|
Jenkins build for PR 1276 build 9 Build Successful: |
ben-millar
force-pushed
the
bm/CORE-17476/rpc-endpoints
branch
from
888b48f to
fff4e11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a related corda-runtime-os PR (HERE), we're adding a
ClusterIPload balancer service to each Corda worker which will distribute HTTP calls to various instances of each worker type. The endpoints for these services are then passed into theFlowWorkerstartup args in key:value pairs. This PR adds these keys to the API so that we can query the endpoint map passed into theFlowWorker.PR Building with these changes: https://ci02.dev.r3.com/job/Corda5/job/corda-runtime-os/job/PR-4823/8/