Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CORE-16870 Support nullable parameters in queries #1302

Closed
wants to merge 3 commits into from
Closed

CORE-16870 Support nullable parameters in queries #1302

wants to merge 3 commits into from

Conversation

nkovacsx
Copy link
Contributor

@nkovacsx nkovacsx commented Oct 17, 2023 •
edited
Loading

Overview

Right now nullable parameters are not supported in named queries, after this change we'll support setting null parameters. This feature was requested by various teams before.

@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Oct 17, 2023 •
edited
Loading

Jenkins build for PR 1302 build 3

Build Successful:
Jar artifact version produced by this PR: 5.2.0.3-alpha-1700216516882

@nkovacsx nkovacsx requested a review from lankydan October 17, 2023 13:02
@github-actions GitHub Actions
Copy link

This PR is stale because it has been open 7 days with no activity. Remove the Stale label or add a comment - otherwise this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Nov 17, 2023
@nkovacsx nkovacsx changed the base branch from release/os/5.1 to release/os/5.2 November 17, 2023 10:19
@nkovacsx
Merge branch 'release/os/5.2' of https://github.com/corda/corda-api i…
c883bce 
…nto nandor/CORE-16870/nullable-params-queries

# Conflicts:
#	gradle.properties
@nkovacsx nkovacsx removed the Stale label Nov 17, 2023
@nkovacsx nkovacsx marked this pull request as ready for review November 17, 2023 10:21
@nkovacsx nkovacsx requested a review from a team as a code owner November 17, 2023 10:21
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@corda-jenkins-ci02
Copy link
Contributor

Scanning for breaking API changes introduced by this PR

Scan Failed: https://ci02.dev.r3.com/job/Corda5/job/corda-api-compatibility/job/PR-1302/2/

If the breaking changes are intentional, run ./gradlew cementApi and get approval from the Corda team leads.

@corda-jenkins-ci02
Copy link
Contributor

Non-blocking downstream job failed for corda-non-functional-test

https://ci02.dev.r3.com/job/Corda5/job/corda-api-compatibility/job/PR-1302/2/ has failed for PR 1302 build 2

Please investigate if your changes may have broken compilation on https://github.com/corda/corda-non-functional-test

@corda-jenkins-ci02
Copy link
Contributor

Non-blocking downstream job failed for corda-e2e-test

https://ci02.dev.r3.com/job/Corda5/job/corda-api-compatibility/job/PR-1302/2/ has failed for PR 1302 build 2

Please investigate if your changes may have broken compilation on https://github.com/corda/corda-e2e-tests

@github-actions GitHub Actions
Copy link

This PR is stale because it has been open 7 days with no activity. Remove the Stale label or add a comment - otherwise this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Nov 27, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2023

This PR was closed because it has been stale for 7 days with no activity.

@github-actions github-actions bot closed this Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lankydan lankydan Awaiting requested review from lankydan

Assignees
No one assigned
Labels
Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nkovacsx