CORE-17012 dlq topic to be used by multi source mediator for producer serialization errors #1304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… serialization errors
LWogan
requested review from
driessamyn,
jasonbyrner3,
dimosr,
ronanbrowne,
rick-r3,
simon-johnson-r3,
blsemo,
Omar-awad,
aditisdesai,
vinir3,
vkolomeyko,
thiagoviana and
Sakpal
as code owners
|
On second thought, im going to close this. It doesnt make sense to me that we DLQ a producer record that fails to send. We already log it. That should be enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not possible for a multi source mediator to determine which topic a record came from which triggered an output record that failed to serialize and therefore should be DLQ'd.
Adding a common topic for all mediators to send a DLQ record for to record serialization failures.
Open to debate whether we should even bother DLQing this records. However as we DLQ these in the S+E this seems the only way to preserve that logic