Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DA5-5 fix api version #1323

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

vlajos
Copy link
Contributor

@vlajos vlajos commented Nov 1, 2023

Mainly to avoid gradle mixing version numbers.
Required to run the e2e repository's tests.
Background:
https://r3holdco.slack.com/archives/C039J1A3ZQB/p1698657116094349

@vlajos vlajos requested a review from ronanbrowne November 1, 2023 15:00
@corda-jenkins-ci02
Copy link
Contributor

Scanning for breaking API changes introduced by this PR

Scan Failed: https://ci02.dev.r3.com/job/Corda5/job/corda-api-compatibility/job/PR-1323/1/

If the breaking changes are intentional, run ./gradlew cementApi and get approval from the Corda team leads.

@corda-jenkins-ci02
Copy link
Contributor

Jenkins build for PR 1323 build 1

Build Successful:
Jar artifact version produced by this PR: 5.1.0.200-DA-alpha-1698850811403

@vlajos vlajos marked this pull request as ready for review November 1, 2023 15:14
@corda-jenkins-ci02
Copy link
Contributor

Non-blocking downstream job failed for corda-non-functional-test

https://ci02.dev.r3.com/job/Corda5/job/corda-api-compatibility/job/PR-1323/1/ has failed for PR 1323 build 1

Please investigate if your changes may have broken compilation on https://github.com/corda/corda-non-functional-test

@vlajos vlajos merged commit e2e5fe2 into release/c5-digital-assets Nov 1, 2023
2 checks passed
@vlajos vlajos deleted the vlajos/DA5-5-fix-api-version branch November 1, 2023 15:16
@corda-jenkins-ci02
Copy link
Contributor

Non-blocking downstream job failed for corda-e2e-test

https://ci02.dev.r3.com/job/Corda5/job/corda-api-compatibility/job/PR-1323/1/ has failed for PR 1323 build 1

Please investigate if your changes may have broken compilation on https://github.com/corda/corda-e2e-tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants