Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CORE-12165: key-rotation messages and config #1326

Closed
wants to merge 42 commits into from
Closed

CORE-12165: key-rotation messages and config #1326

wants to merge 42 commits into from

Conversation

dickon
Copy link
Contributor

@dickon dickon commented Nov 3, 2023

👮🏻👮🏻👮🏻 !!!! DESCRIBE YOUR CHANGES HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you run the unit, integration and smoke tests as described here?
  • If you added public APIs, did you write the JavaDocs?
  • If the changes are of interest to application developers, have you added them to the changelog (/docs/source/changelog.rst), and potentially the release notes (/docs/source/release-notes.rst)?
  • If you are contributing for the first time, please read the contributor agreement now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thanks for your code, it's appreciated! :)

@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Nov 3, 2023 •
edited
Loading

Scanning for breaking API changes introduced by this PR

Scan Failed: https://ci02.dev.r3.com/job/Corda5/job/corda-api-compatibility/job/PR-1326/2/

If the breaking changes are intentional, run ./gradlew cementApi and get approval from the Corda team leads.

@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Nov 3, 2023 •
edited
Loading

Jenkins build for PR 1326 build 2

Build Successful:
Jar artifact version produced by this PR: 5.1.0.38-alpha-1699268962803

@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Nov 3, 2023 •
edited
Loading

Non-blocking downstream job failed for corda-non-functional-test

https://ci02.dev.r3.com/job/Corda5/job/corda-api-compatibility/job/PR-1326/2/ has failed for PR 1326 build 2

Please investigate if your changes may have broken compilation on https://github.com/corda/corda-non-functional-test

@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Nov 3, 2023 •
edited
Loading

Non-blocking downstream job failed for corda-e2e-test

https://ci02.dev.r3.com/job/Corda5/job/corda-api-compatibility/job/PR-1326/2/ has failed for PR 1326 build 2

Please investigate if your changes may have broken compilation on https://github.com/corda/corda-e2e-tests

@vkolomeyko
Copy link
Contributor

Do we need this change into 5.1 branch? I also see that Jira https://r3-cev.atlassian.net/browse/CORE-12165 is scheduled for C5.2.

@dickon dickon force-pushed the feature/CORE-12165/key-rotation branch from ea860b5 to 6924e79 Compare November 6, 2023 11:08
ronanbrowne and others added 11 commits November 10, 2023 18:32
@ronanbrowne
ES-1608: 5.2 release Branch set up
af010b1
@jacob-scott3141
Add scans to CODEOWNERS
396b063
Merging forward updates from release/os/5.1 to release/os/5.2 - 2023-…
cc58da1 
…11-13
@ronanbrowne
Update JenkinsfileMergeAutomation
ca6ff5d
@ronanbrowne
Update JenkinsfileMergeAutomation
d4d8b19
@ronanbrowne
Merge pull request #1336 from corda/merge-release/os/5.1-release/os/5…
ccbd420 
….2-2023-11-13-1

ES-1621: Merging forward updates from release/os/5.1 to release/os/5.2 - 2023-11-13
@jacob-scott3141
Merge pull request #1334 from jacob-scott3141/patch-1
166e046 
ES-1620: Add scans to CODEOWNERS
@jacob-scott3141
Create remove-stale-prs workflow (#1337)
2325745
@jacob-scott3141
CementApi and update 5.1.0 files to 5.2.0 (#1338)
dc99f63
@nikinagy
CORE-17355 - Reduce number of p2p e2e sessions maintained per pair of…
38848f6 
… vnodes (#1307)

In order to increase our performance, this PR reduces number of p2p e2e sessions maintained per pair of vnodes:
for member <-> MGM communication reduce to 1
for member <-> member communication reduce to 1
@jacob-scott3141
ES-1486 Roll out and activation on all C5 repos (#1344)
e7ccb78 
* Update remove-stale-branches.yml

* Update remove-stale-prs.yml
@github-actions GitHub Actions
Copy link

This PR is stale because it has been open 7 days with no activity. Remove the Stale label or add a comment - otherwise this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Nov 17, 2023
corda-jenkins-ci02 bot and others added 9 commits November 20, 2023 10:17
@corda-jenkins-ci02 @yift-r3
CORE-18390: Allow old version of SetOwnRegistrationStatus in the comm…
f74ecea 
…and (#1342) (#1347)

Co-authored-by: Yiftach Kaplan <[email protected]>
Co-authored-by: Yiftach Kaplan <[email protected]>
@dickon
Merge remote-tracking branch 'origin/release/os/5.2' into feature/COR…
a335d2b 
…E-12165/key-rotation

# Conflicts:
#	gradle.properties
@dickon
Merge pull request #1350 from corda/dickon/CORE-12165/key-rotation-me…
1c03eb3 
…rge-5.2

CORE-12165: merge in 5.2 changes
@dickon
add keyType and clarify names in IndividualKeyRotationRequest
9bff0c1
@dickon
remove simulate, limit and timeToLive for now, to keep things simple …
684fa3b 
…until we understand the problems
@dickon
fix rebase error
846a2ab
@dickon
improve consistency
763cdb9
@dickon
add dot
d2da8c5
@dickon
Merge pull request #1349 from corda/dickon/CORE-12165-feature-rotatio…
dc0b8c8 
…n-no-limit

CORE-12165: undo revert of revert and remove limit and time to live on key rotation
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dickon dickon closed this Nov 20, 2023
@dickon
Copy link
Contributor Author

dickon commented Nov 20, 2023

duplicate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driessamyn driessamyn Awaiting requested review from driessamyn

@jasonbyrner3 jasonbyrner3 Awaiting requested review from jasonbyrner3

@dimosr dimosr Awaiting requested review from dimosr

@ronanbrowne ronanbrowne Awaiting requested review from ronanbrowne

@rick-r3 rick-r3 Awaiting requested review from rick-r3

@simon-johnson-r3 simon-johnson-r3 Awaiting requested review from simon-johnson-r3

@blsemo blsemo Awaiting requested review from blsemo

@Omar-awad Omar-awad Awaiting requested review from Omar-awad

@aditisdesai aditisdesai Awaiting requested review from aditisdesai

@vinir3 vinir3 Awaiting requested review from vinir3

@vkolomeyko vkolomeyko Awaiting requested review from vkolomeyko

@thiagoviana thiagoviana Awaiting requested review from thiagoviana

@Sakpal Sakpal Awaiting requested review from Sakpal

Assignees
No one assigned
Labels
Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dickon @vkolomeyko @anien @ronanbrowne @jacob-scott3141 @nikinagy