CORE-18180 Correct StateRef.toString
#1327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lankydan
requested review from
driessamyn,
jasonbyrner3,
dimosr,
ronanbrowne,
rick-r3,
simon-johnson-r3,
blsemo,
Omar-awad,
aditisdesai,
vinir3,
vkolomeyko,
thiagoviana and
Sakpal
as code owners
lankydan
force-pushed
the
dan/CORE-18180-state-ref-comma-parsing
branch
3 times, most recently
from
ecf9f71 to
405fe8b
Compare
|
Scanning for breaking API changes introduced by this PR Scan Succeeded |
|
Jenkins build for PR 1327 build 5 Build Successful: |
vkolomeyko
reviewed
Nov 6, 2023
ledger/ledger-utxo/src/main/java/net/corda/v5/ledger/utxo/StateRef.java
Outdated
Show resolved
Hide resolved
The index in `StateRef.toString` was being formatted which added commas to the output. This created an invalid string representation of a `StateRef`, causing errors if we ever called `StateRef.parse` on the output of `StateRef.toString`. Rely on normal string concatenation instead of `MessageFormat.format` to resolve this.
lankydan
force-pushed
the
dan/CORE-18180-state-ref-comma-parsing
branch
from
405fe8b to
94ac6e9
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
charlieR3
pushed a commit
that referenced
this pull request
Nov 10, 2023
The index in `StateRef.toString` was being formatted which added commas to the output. This created an invalid string representation of a `StateRef`, causing errors if we ever called `StateRef.parse` on the output of `StateRef.toString`. Rely on normal string concatenation instead of `MessageFormat.format` to resolve this.
dickon
pushed a commit
that referenced
this pull request
Nov 17, 2023
The index in `StateRef.toString` was being formatted which added commas to the output. This created an invalid string representation of a `StateRef`, causing errors if we ever called `StateRef.parse` on the output of `StateRef.toString`. Rely on normal string concatenation instead of `MessageFormat.format` to resolve this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The index in
StateRef.toStringwas being formatted which added commas to the output. This created an invalid string representation of aStateRef, causing errors if we ever calledStateRef.parseon the output ofStateRef.toString.Rely on normal string concatenation instead of
MessageFormat.formatto resolve this.