Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CORE-12165: undo revert of revert and remove limit and time to live on key rotation #1349

Merged
merged 5 commits into from
Nov 20, 2023
Merged

CORE-12165: undo revert of revert and remove limit and time to live on key rotation #1349

merged 5 commits into from
Nov 20, 2023

Conversation

dickon
Copy link
Contributor

@dickon dickon commented Nov 17, 2023

Also add key type on individual key rotation messages, and clarify docstrings.

@dickon dickon force-pushed the dickon/CORE-12165-feature-rotation-no-limit branch from 2138748 to fc5dfdf Compare November 17, 2023 12:56
@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Nov 17, 2023 •
edited
Loading

Scanning for breaking API changes introduced by this PR

Scan Succeeded

@corda-jenkins-ci02
Copy link
Contributor

Non-blocking downstream job failed for corda-non-functional-test

https://ci02.dev.r3.com/job/Corda5/job/corda-api-compatibility/job/PR-1349/1/ has failed for PR 1349 build 1

Please investigate if your changes may have broken compilation on https://github.com/corda/corda-non-functional-test

@corda-jenkins-ci02
Copy link
Contributor

Non-blocking downstream job failed for corda-e2e-test

https://ci02.dev.r3.com/job/Corda5/job/corda-api-compatibility/job/PR-1349/1/ has failed for PR 1349 build 1

Please investigate if your changes may have broken compilation on https://github.com/corda/corda-e2e-tests

@dickon dickon force-pushed the dickon/CORE-12165-feature-rotation-no-limit branch 3 times, most recently from e419c17 to a9f4747 Compare November 17, 2023 17:07
@dickon dickon changed the title CORE-12165: remove limit and time to live on key rotation CORE-12165: take changes from 5.2, undo revert of revert and remove limit and time to live on key rotation Nov 17, 2023
@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Nov 17, 2023 •
edited
Loading

Jenkins build for PR 1349 build 11

Build Successful:
Jar artifact version produced by this PR: 5.2.0.4-alpha-1700498836271

@dickon dickon mentioned this pull request Nov 20, 2023
Merged
anien
anien reviewed Nov 20, 2023
View reviewed changes
...esources/avro/net/corda/data/crypto/wire/ops/key/rotation/IndividualKeyRotationResponse.avsc Outdated
@@ -27,7 +27,7 @@
{
"name": "targetKeyAlias",
"type": "string",
"doc": "Specifies the wrapped key to rotate"
"doc": "Specifies the alias of the key that should be rotated"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add dot at the end of the sentence.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@dickon dickon force-pushed the dickon/CORE-12165-feature-rotation-no-limit branch 2 times, most recently from 3dcc481 to 92dee26 Compare November 20, 2023 16:29
@dickon dickon force-pushed the dickon/CORE-12165-feature-rotation-no-limit branch from 92dee26 to d2da8c5 Compare November 20, 2023 16:46
@dickon dickon requested a review from a team as a code owner November 20, 2023 16:46
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dickon dickon merged commit dc0b8c8 into feature/CORE-12165/key-rotation Nov 20, 2023
2 checks passed
@dickon dickon deleted the dickon/CORE-12165-feature-rotation-no-limit branch November 20, 2023 16:54
@dickon dickon changed the title CORE-12165: take changes from 5.2, undo revert of revert and remove limit and time to live on key rotation CORE-12165: undo revert of revert and remove limit and time to live on key rotation Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anien anien anien approved these changes

@driessamyn driessamyn Awaiting requested review from driessamyn

@jasonbyrner3 jasonbyrner3 Awaiting requested review from jasonbyrner3

@dimosr dimosr Awaiting requested review from dimosr

@ronanbrowne ronanbrowne Awaiting requested review from ronanbrowne

@rick-r3 rick-r3 Awaiting requested review from rick-r3

@simon-johnson-r3 simon-johnson-r3 Awaiting requested review from simon-johnson-r3

@blsemo blsemo Awaiting requested review from blsemo

@Omar-awad Omar-awad Awaiting requested review from Omar-awad

@aditisdesai aditisdesai Awaiting requested review from aditisdesai

@vinir3 vinir3 Awaiting requested review from vinir3

@vkolomeyko vkolomeyko Awaiting requested review from vkolomeyko

@thiagoviana thiagoviana Awaiting requested review from thiagoviana

@Sakpal Sakpal Awaiting requested review from Sakpal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dickon @anien