Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE-18458: remove unused config and IndividualKeyRotationResponse #1355

Merged

Conversation

dickon
Copy link
Contributor

@dickon dickon commented Nov 21, 2023

No description provided.

@dickon dickon requested a review from a team as a code owner November 21, 2023 17:34
@corda-jenkins-ci02
Copy link
Contributor

Scanning for breaking API changes introduced by this PR

Scan Succeeded

@vkolomeyko
Copy link
Contributor

Is title on this PR accurate? ("CORE-12165: remove unused config and IndividualKeyRotationResponse")
From what I can see there is not much removal going on, but a bunch of stuff has been added. Also https://r3-cev.atlassian.net/browse/CORE-12165 refers to an Epic, I though the idea was to associate individual PR with stories under the epic.

@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Nov 21, 2023

Jenkins build for PR 1355 build 3

Build Successful:
Jar artifact version produced by this PR: 5.2.0.5-alpha-1700602475789

@anien
Copy link
Contributor

anien commented Nov 21, 2023

Is title on this PR accurate? ("CORE-12165: remove unused config and IndividualKeyRotationResponse") From what I can see there is not much removal going on, but a bunch of stuff has been added. Also https://r3-cev.atlassian.net/browse/CORE-12165 refers to an Epic, I though the idea was to associate individual PR with stories under the epic.

I think this should point to a feature key rotation branch, then we can see the removal of the code. We point to an epic in some cases which comes out of the review of a feature branch to release branch. But for this particular removal we do have a jira ticket. So I will change the ticket number.

@anien anien changed the base branch from release/os/5.2 to feature/CORE-12165/key-rotation November 21, 2023 20:55
@anien anien changed the title CORE-12165: remove unused config and IndividualKeyRotationResponse CORE-18458: remove unused config and IndividualKeyRotationResponse Nov 21, 2023
Copy link
Contributor

@anien anien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@corda-jenkins-ci02
Copy link
Contributor

Non-blocking downstream job failed for corda-e2e-test

https://ci02.dev.r3.com/job/Corda5/job/corda-api-compatibility/job/PR-1355/2/ has failed for PR 1355 build 2

Please investigate if your changes may have broken compilation on https://github.com/corda/corda-e2e-tests

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@anien anien merged commit 69b2947 into feature/CORE-12165/key-rotation Nov 21, 2023
2 checks passed
@anien anien deleted the dickon/CORE-12165-remove-unnecessary branch November 21, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants