Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE-18168: Add Kafka payload and config to support changing user password #1356

Merged

Conversation

Tom-Fitzpatrick
Copy link
Contributor

@Tom-Fitzpatrick Tom-Fitzpatrick commented Nov 21, 2023

Creates

  • ChangeUserPasswordOtherRequest.avsc
  • ChangeUserPasswordSelfRequest.avsc

These will be used to allow users to change their own password, and for an admin to change a particular user's password.

This also adds new config settings related to password expiry, specifically, default values for how long a password should last before expiring depending on whether a user or an admin changed the password.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title failed to match regex -> ^((CORDA|EG|ENT|INFRA|CORE|DOC|ES)-\d+)(.*)

@corda-jenkins-ci02
Copy link
Contributor

Scanning for breaking API changes introduced by this PR

Scan Succeeded

@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Nov 22, 2023

Jenkins build for PR 1356 build 6

Build Successful:
Jar artifact version produced by this PR: 5.2.0.5-alpha-1700666330386

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title failed to match regex -> ^((CORDA|EG|ENT|INFRA|CORE|DOC|ES)-\d+)(.*)

@Tom-Fitzpatrick Tom-Fitzpatrick changed the title Support changing user password CORE-18168: Add Kafka payload and config to support changing user password Nov 22, 2023
@Tom-Fitzpatrick Tom-Fitzpatrick marked this pull request as ready for review November 22, 2023 14:06
@Tom-Fitzpatrick Tom-Fitzpatrick requested a review from a team as a code owner November 22, 2023 14:06
@github-actions github-actions bot dismissed stale reviews from themself November 22, 2023 14:06

All good!

@Tom-Fitzpatrick Tom-Fitzpatrick force-pushed the tomf/CORE-18168/support-user-password-changes branch from 4e9b4db to d1173a8 Compare November 22, 2023 14:07
@Tom-Fitzpatrick Tom-Fitzpatrick force-pushed the tomf/CORE-18168/support-user-password-changes branch from 9084d65 to bf53639 Compare November 22, 2023 15:18
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@vkolomeyko vkolomeyko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tom-Fitzpatrick Tom-Fitzpatrick merged commit 77ff03a into release/os/5.2 Nov 23, 2023
4 checks passed
@Tom-Fitzpatrick Tom-Fitzpatrick deleted the tomf/CORE-18168/support-user-password-changes branch November 23, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants