Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE-18813 - enable Dependabot #1375

Merged
merged 11 commits into from
Dec 11, 2023

Conversation

driessamyn
Copy link
Contributor

@driessamyn driessamyn commented Dec 1, 2023

  • Use gradle catalogue using a versions toml file to define library versions.
  • Enable Dependabot so it can raise PRs to update dependencies

image

E.g. https://github.com/corda/corda-api/pull/1383/files

NOTE: this doesn't complete the work as there are some gaps, but this evolved from the POC and may be a good first step.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title failed to match regex -> ^((CORDA|EG|ENT|INFRA|CORE|DOC|ES|DA5)-\d+)(.*)

@driessamyn driessamyn force-pushed the driessamyn/poc/version-catalogue branch from e6a015b to a365fe7 Compare December 1, 2023 12:10
@corda-jenkins-ci02
Copy link
Contributor

Scanning for breaking API changes introduced by this PR

Scan Succeeded

@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Dec 1, 2023

Jenkins build for PR 1375 build 10

Build Successful:
Jar artifact version produced by this PR: 5.2.0.12-alpha-1702304568719

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title failed to match regex -> ^((CORDA|EG|ENT|INFRA|CORE|DOC|ES|DA5)-\d+)(.*)

@driessamyn driessamyn changed the title POC toml file version catalogue. CORE-18813 - enable Dependabot Dec 8, 2023
@github-actions github-actions bot dismissed stale reviews from themself December 8, 2023 17:31

All good!

gradle.properties Outdated Show resolved Hide resolved
@driessamyn driessamyn marked this pull request as ready for review December 8, 2023 17:40
@driessamyn driessamyn requested review from a team as code owners December 8, 2023 17:40
ronanbrowne
ronanbrowne previously approved these changes Dec 11, 2023
Copy link
Contributor

@ronanbrowne ronanbrowne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ronanbrowne ronanbrowne self-requested a review December 11, 2023 14:26
@driessamyn driessamyn merged commit 1f25021 into release/os/5.2 Dec 11, 2023
9 checks passed
@driessamyn driessamyn deleted the driessamyn/poc/version-catalogue branch December 11, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants