-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add schema for test overrides #2
Conversation
e789812
to
08b9bab
Compare
- write and improve tests - deprecate `log_contains` and `no_log_contains` in favour of new `log` struct - add `expect_id` and `no_expect_id` to simplify standard log output matches
08b9bab
to
18e88f1
Compare
- deprecate some fields in favor of new ones - add `retry_once` option
18e88f1
to
2434b86
Compare
@theseion You are committing the generated files. I don't think we want that. |
Yeah, wasn't sure about that. I did it mainly because |
@fzipi I figured out a way to reuse code. I'd appreciate some feedback. The markdown output is still not perfect (references to external code are documented a bit weirdly), but in general it works well. |
Awesome fix! Now I need to look at the weird stuff and compare. It took me some time the first iteration to get it in good shape... |
Can we merge this PR for now? I can't work on finishing the implementation in go-ftw to support the nginx tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, let's move forward with this.
No description provided.