-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve rule configuration #314
base: main
Are you sure you want to change the base?
Conversation
theseion
commented
Dec 22, 2024
- Configure rules to update in a separate configuration file
- Use generic script to configure rules that doesn't rely on exact match of rule
- Log which rules are configured
- Log when a rule that should be configured wasn't found
32ebed2
to
2f1b656
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, it is difficult to have tests for this I guess.
9a7e956
to
bb4f450
Compare
- Configure rules to update in a separate configuration file - Use generic script to configure rules that doesn't rely on exact match of rule - Log which rules are configured - Log when a rule that should be configured wasn't found
a7ef97c
to
8b1857a
Compare
8b1857a
to
9f08de4
Compare
@fzipi I've implemented a simple way to test the logic. That did uncover a few issues with the code I had written. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!