Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update arguments.md #6460

Merged
merged 6 commits into from
Dec 30, 2024
Merged

Update arguments.md #6460

merged 6 commits into from
Dec 30, 2024

Conversation

CharlieTLe
Copy link
Member

Removed obsolete -promql.lookback-delta option (deprecated since Cortex 1.2, replaced with -querier.lookback-delta). #3144

CharlieTLe and others added 4 commits December 24, 2024 18:10
Removed obsolete `-promql.lookback-delta` option (deprecated since Cortex 1.2, replaced with `-querier.lookback-delta`). #3144

Signed-off-by: Charlie Le <[email protected]>
Signed-off-by: Charlie Le <[email protected]>
...interval`

Query-frontend: removed `-querier.split-queries-by-day` (deprecated in Cortex 0.4.0). Please use `-querier.split-queries-by-interval` instead. #3813
Signed-off-by: Charlie Le <[email protected]>
Flag `ingester.max-samples-per-query` was removed in #4812 as part of the chunk storage removal.

Signed-off-by: Charlie Le <[email protected]>
Copy link
Member

@friedrichg friedrichg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this

@@ -63,7 +63,7 @@ The next three options only apply when the querier is used together with the Que

If set to true, will cause the query frontend to mutate incoming queries and align their start and end parameters to the step parameter of the query. This improves the cacheability of the query results.

- `-querier.split-queries-by-day`
- `-querier.split-queries-by-interval`

If set to true, will cause the query frontend to split multi-day queries into multiple single-day queries and execute them in parallel.
Copy link
Member

@friedrichg friedrichg Dec 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this flag should be set to 24h multiples. "If set to true" is not valid

@@ -393,9 +393,7 @@ Valid per-tenant limits are (with their corresponding flags for default values):

- `max_series_per_query` / `-ingester.max-series-per-query`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is deprecated. The new one is -querier.max-fetched-series-per-query and is enforced at queriers,ruler and store-gateways

Copy link
Member

@friedrichg friedrichg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 30, 2024
@friedrichg friedrichg merged commit c243963 into master Dec 30, 2024
17 checks passed
@friedrichg friedrichg deleted the CharlieTLe-patch-2 branch December 30, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/documentation lgtm This PR has been approved by a maintainer size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants