Use slice pooling to populate the query stream response #6466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: alanprot <[email protected]>
alanprot
commented
Dec 31, 2024
Comment on lines
+3069
to
+3093
| func (i *Ingester) getInstanceLimits() *InstanceLimits { | ||
| // Don't apply any limits while starting. We especially don't want to apply series in memory limit while replaying WAL. | ||
| if i.State() == services.Starting { | ||
| return nil | ||
| } | ||
|
|
||
| if i.cfg.InstanceLimitsFn == nil { | ||
| return defaultInstanceLimits | ||
| } | ||
|
|
||
| l := i.cfg.InstanceLimitsFn() | ||
| if l == nil { | ||
| return defaultInstanceLimits | ||
| } | ||
|
|
||
| return l | ||
| } | ||
|
|
||
| // stopIncomingRequests is called during the shutdown process. | ||
| func (i *Ingester) stopIncomingRequests() { | ||
| i.stoppedMtx.Lock() | ||
| defer i.stoppedMtx.Unlock() | ||
| i.stopped = true | ||
| } | ||
|
|
There was a problem hiding this comment.
No changes on these functions.. I just moved to be close to the other ingesters functions.
yeya24
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Use slice pooling to populate the query stream response.
Under very high query load (lots of rules), the slice created when returning the query response is a big part of the alloc memory causing more frequent GC.
This PR is proposing to reuse those slices in order to safe GC CPU cycles.
Benchmark:
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]