New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky fuzz tests with count_values #6474

Merged

yeya24 merged 1 commit into cortexproject:master from harry671003:fix_fuzz_count_values

Jan 3, 2025

Contributor

harry671003 commented Jan 2, 2025

What this PR does:

Fixes flakiness in fuzz tests for count_values func.
count_values returns a float in the metric which is not always accurate.

[
  {
    "metric": { "job": "prometheus", "value": "0" },
    "value": [1734628158, "5"]
  },
  {
    "metric": { "job": "prometheus", "value": "16254.5" },
    "value": [1734628158, "9"]
  },
  {
    "metric": { "job": "prometheus", "value": "17551.083333333336" },
    "value": [1734628158, "1"]
  }
]

Example of one such failure: https://github.com/cortexproject/cortex/actions/runs/12586943624/job/35081958645

Which issue(s) this PR fixes:
Fixes #

Checklist

Tests updated
Documentation added
CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]


          Fix flaky fuzz tests with count_values

88328a3

Signed-off-by: 🌲 Harry 🌊 John 🏔 <[email protected]>

pull-request-size bot added the size/M label

dosubot bot added the type/flaky-test label

yeya24 approved these changes

View reviewed changes

Contributor

yeya24 left a comment

Thanks!

yeya24 merged commit c685cf4 into cortexproject:master

17 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M type/flaky-test