Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove multiple dots in redis flags #6476

Merged
merged 5 commits into from
Jan 6, 2025
+47 −47
Merged

remove multiple dots in redis flags #6476

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e7fa158
remove multiple dots in redis flags
won-js Jan 3, 2025
197d3e4
update docs
won-js Jan 4, 2025
a6afa70
add BUGFIX entry in the CHANGELOG
won-js Jan 6, 2025
3258100
Update CHANGELOG.md
friedrichg Jan 6, 2025
8c392f9
remove white space
friedrichg Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions pkg/storage/tsdb/redis_client_config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ package tsdb

import (
"flag"

"time"

"github.com/pkg/errors"
Expand Down Expand Up @@ -60,7 +59,7 @@ func (cfg *RedisClientConfig) RegisterFlagsWithPrefix(f *flag.FlagSet, prefix st
f.StringVar(&cfg.MasterName, prefix+"master-name", "", "Specifies the master's name. Must be not empty for Redis Sentinel.")
f.IntVar(&cfg.CacheSize, prefix+"cache-size", 0, "If not zero then client-side caching is enabled. Client-side caching is when data is stored in memory instead of fetching data each time. See https://redis.io/docs/manual/client-side-caching/ for more info.")
f.BoolVar(&cfg.TLSEnabled, prefix+"tls-enabled", false, "Whether to enable tls for redis connection.")
cfg.TLS.RegisterFlagsWithPrefix(prefix, f)
cfg.TLS.RegisterFlagsWithPrefix(prefix[:len(prefix)-1], f)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocker to this PR. I wonder if we should just unify our flags to always remove . in its flag description and add . in the prefix instead

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good idea, but it seems like there would be a lot of code that needs to be changed.

cfg.SetAsyncCircuitBreaker.RegisterFlagsWithPrefix(f, prefix+"set-async.")
}

Expand Down
Loading