Code

Add custom joins#691

Code

Open

cmacmackin wants to merge 27 commits intocosmocode:mastercosmocode/dokuwiki-plugin-struct:masterfrom cmacmackin:add_custom_joinscmacmackin/dokuwiki-plugin-struct:add_custom_joinsCopy head branch name to clipboard

+1,079-278

Commits

Commits on Nov 18, 2023

• Added support for parsing join configurations for aggregations

  cmacmackin

  committed
  d39cf66

• Collect data on how to join schemas

  cmacmackin

  committed
  c5f5f20

• Updated tests to include JOIN ON logic

  Show description for d224d1c
  cmacmackin

  committed
  d224d1c

• Complete processing of JOIN configurations

  Show description for e3fd32b
  cmacmackin

  committed
  e3fd32b

• Add (empty) join data to schema data

  cmacmackin

  committed
  70ec5d2

• Initial implementation of custom JOINs for simple types

  Show description for 8df3799
  cmacmackin

  committed
  8df3799

• Move logic for selecting columns inside column types

  cmacmackin

  committed
  a1c85df

• Refactored selecting columns to hide complexity

  Show description for 395df62
  cmacmackin

  committed
  395df62

• Add tests that page exists and is accessible for custom joins

  cmacmackin

  committed
  59b0a86

• Refactored filtering so can reuse logic for joins

  cmacmackin

  committed
  4ff5cce

• Refactor how join conditions are handled

  cmacmackin

  committed
  3605876

Commits on Nov 19, 2023

• Fixed regression from rebasing

  cmacmackin

  committed
  d452b99

• Further regression-fixes from rebasing

  cmacmackin

  committed
  3cbc3ab

• Fixed bug building searches with custom joins

  cmacmackin

  committed
  096529f

• Updated test in line with refactoring

  Show description for 4ebe1fc
  cmacmackin

  committed
  4ebe1fc

• Fixed code-sniffer issues

  cmacmackin

  committed
  e1da59c

Commits on Nov 29, 2023

• Separated additional joins from getSqlCompareValue

  Show description for 8d0bdc3
  cmacmackin

  committed
  8d0bdc3

Commits on Nov 30, 2023

• Decided not to support joins over multi-valued columns

  cmacmackin

  committed
  5d60c3b

• Attempt to implement joins against page titles

  Show description for 2e6f73c
  cmacmackin

  committed
  2e6f73c

• Improved robustness of addLeftJoin

  Show description for 38630c3
  cmacmackin

  committed
  38630c3

• Fixed style problems flagged on CI

  cmacmackin

  committed
  de60ccf

• Shortened long line

  cmacmackin

  committed
  9df21fc

• Fixed code style issues

  cmacmackin

  committed
  2e02e3c

• Added tests for joining against page titles and summaries

  Show description for 330a612
  cmacmackin

  committed
  330a612

• Move page-type-specific join logic into separate method

  cmacmackin

  committed
  f4d9287

• Make sure can wrap either scalar or arrays of values

  cmacmackin

  committed
  474f0ea

• Removed trailing whitespace

  cmacmackin

  committed
  bbd6891