-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add titan network #5745
add titan network #5745
Conversation
This looks to be a good submission. The only issue I notice is that the 'chain' 'ttnt' images seem to be duplicates, which I believe can be reduced to a single set of images. |
Thanks, I changed this |
"$schema": "../chain.schema.json", | ||
"chain_name": "titannet", | ||
"chain_type": "cosmos", | ||
"chain_id": "titan-test-4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a testnet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a testnet?
Yes, this is indeed a testnet (titan-test-4) as shown in the chain.json configuration.
We're in the final preparation phase before mainnet launch. At this stage, we aim to test IBC channel connectivity between our Testnet and OSMO, particularly focusing on TNT4 cross-chain transfers to OSMO to validate additional functionalities.
Both our team and community are fully aware of its testnet status. We kindly request approval for this submission. We're open to any modification requirements or guidelines you may have and can adjust according to your specifications. What are your requirements for this integration?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case, the value for "network_type"
shouldn't be "mainnet"
, but instead should be "testnet"
.
In addition, the chain_name should be titannettestnet (in the assetlist.json, the chain.json, versions.json, all ibc files, and the directory name. The directory must also be relocated inside the /testnets/ directory, where you'll see that all other testnets have chain_name as +'testnet'.
"website": "https://titannet.io/", | ||
"pretty_name": "Titan Network", | ||
"status": "live", | ||
"network_type": "mainnet", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a mainnet
@@ -0,0 +1,78 @@ | |||
{ | |||
"$schema": "../assetlist.schema.json", | |||
"chain_name": "titannet", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"titannettestnet"
"connection_id": "connection-2838" | ||
}, | ||
"chain_2": { | ||
"chain_name": "titannet", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"titannettestnet"
@@ -0,0 +1,126 @@ | |||
{ | |||
"$schema": "../chain.schema.json", | |||
"chain_name": "titannet", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"titannettestnet"
@@ -0,0 +1,33 @@ | |||
{ | |||
"$schema": "../versions.schema.json", | |||
"chain_name": "titannet", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"titannettestnet"
], | ||
"images": [ | ||
{ | ||
"png": "https://raw.githubusercontent.com/cosmos/chain-registry/master/titanchain/images/ttnt.png", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if the images are relocated to /testnets/titannettestnet/images/, then all these path must also be updated. For now, it is permissible to leave the images under /titannet/images/, but many teams add them images to the testnet images directory first, and then move them over to the mainnet one once the mainnet is registered.
No description provided.